Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VDD source for the ADC #181

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Conversation

diondokter
Copy link
Contributor

Hey, props to you guys! This crate is really easy to add stuff in. (Well, so far at least 😉)

I missed the option for measuring the VDD voltage and all non-9160 mcu's support it.
So I added a struct and made the channel_mappings implement it for me.

The read function now checks for 'channel' 8 as well.

Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesmunns jamesmunns merged commit 1e63c04 into nrf-rs:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants