fix(core): support alias packages in affected locators detection #13585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested changes
Dec 7, 2022
|
|
||
| // check if it's an alternative package e.g. npm:@myorg/[email protected] | ||
| // standard package versions do not contain `@` | ||
| const npmPackage = change.value.rhs.split('@').slice(0, -1).join('@'); |
There was a problem hiding this comment.
This seems wrong that the path does not match the name of the project. I expect it should match because the "alias"ed path is just where to get a package from.. the real name of the package is.. the property name.
FrozenPandaz
approved these changes
Dec 9, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Alias packages break the affected locators' package checking (more info in #13228)
Expected Behavior
Locators should support alias packages
Related Issue(s)
Fixes #13228