feat(core): support npm workspaces in lock file utils #13695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meeroslav
force-pushed
the
npm-workspaces
branch
from
9cad75e to
e6dbcad
Compare
meeroslav
changed the title
meeroslav
force-pushed
the
npm-workspaces
branch
from
c4526f8 to
d2e663b
Compare
meeroslav
commented
Dec 9, 2022
| @@ -2878,44 +2878,28 @@ packages: | |||
| `; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
We are extracting workspace fixtures to workspaces.lock.ts
meeroslav
commented
Dec 9, 2022
| @@ -239,7 +239,7 @@ describe('lock-file', () => { | |||
| const lockFileData = parseNpmLockFile(npmLockFileWithAliases); | |||
| const lockFile = stringifyNpmLockFile(lockFileData); | |||
|
|
|||
| expect(lockFile).toEqual(npmLockFileWithAliases); | |||
There was a problem hiding this comment.
NPM is fragile with props ordering so comparing JSON's makes more sense
meeroslav
force-pushed
the
npm-workspaces
branch
from
d2e663b to
94ba43a
Compare
meeroslav
commented
Dec 9, 2022
| version: value.resolved, | ||
| }), | ||
| ...(!value.integrity && | ||
| value.version && { |
There was a problem hiding this comment.
workspace project has no version in lock file
FrozenPandaz
approved these changes
Dec 12, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Related to #9761