fix(js): generated tsconfig extends path

[SebastienGllmt]

Current Behavior

The generated extends path in tsconfig is incorrectly generated, causing the build to succeed even if it does nothing

Expected Behavior

The paths should either both be absolute, or both be relative.

The easiest way to do this was to pass in the relative path into the checkDependencies function (since the tsConfig variable is not accessed anywhere except to calculate generatedTsConfig.extends), but changing dirnameTsConfig to always be absolute would also be okay

Related Issue(s)

Fixes #28316

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Oct 6, 2024 11:46am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 96aa635. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx affected --targets=lint,test,build,e2e,e2e-ci --base=c2af06e0a12529a5c3d1a09024ccc1fabf4e5604 --head=96aa63595c6df8324660652c214650b5f8201bce --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=c2af06e0a12529a5c3d1a09024ccc1fabf4e5604 --head=96aa63595c6df8324660652c214650b5f8201bce
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[leosvelperez]

hey @SebastienGllmt! Thanks for the detailed investigation!

Let's revert the current change and normalize the file in the helper correctly. That way, we'll guarantee that every consumer of the helper is correct regardless of the path they provide.

[SebastienGllmt]

@leosvelperez would you be able to take that on? I'm not sure exactly where you'd like the normalization to take place. You can create your own PR if you want

[leosvelperez]

Superseded by #29121.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.