Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): normalize paths correctly when creating temporary tsconfig file for incremental builds #29121

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #28316

@leosvelperez leosvelperez self-assigned this Nov 29, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner November 29, 2024 16:47
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 4:49pm

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but left a comment

packages/js/src/utils/buildable-libs-utils.ts Show resolved Hide resolved
@leosvelperez leosvelperez merged commit 201cd89 into master Dec 3, 2024
6 checks passed
@leosvelperez leosvelperez deleted the js/fix-build-libs-temp-tsconfig branch December 3, 2024 14:38
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/js:tsc - wrong extends path used when generated temporary tsconfig
2 participants