Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in preparation for python 3.11 #15523

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Sep 26, 2023

Link to issue number:

In preparation for #12064

Summary of the issue:

  • Certain types which are imported for type checking only are not correctly encapsulated by strings.
  • threading.currentThread() is deprecated in favour of threading.current_thread()
  • with Exception() as ex: syntax is no longer valid in 3.11
  • in wxPython 4.2.0, integers are expected for scaling sizes
  • in wxPython 4.2.0, using AppendColumn is preferred with our current syntax of adding width

Description of user facing changes

None

Description of development approach

Makes various backwards compatible fixes that become compatibility issues when upgrading to python 3.11

Testing strategy:

Test running NVDA with changes, tested in an experimental 3.11 branch as well

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner September 26, 2023 05:42
@AppVeyorBot
Copy link

See test results for failed build of commit fe2d62368a

@AppVeyorBot
Copy link

See test results for failed build of commit fe2d62368a

@AppVeyorBot
Copy link

See test results for failed build of commit 3aa13ea13a

@seanbudd seanbudd force-pushed the minorBackCompatFixes branch from a7bd664 to 3d9a464 Compare September 27, 2023 01:20
@AppVeyorBot
Copy link

See test results for failed build of commit 18b78da5b0

@seanbudd seanbudd merged commit 2c53076 into master Sep 28, 2023
@seanbudd seanbudd deleted the minorBackCompatFixes branch September 28, 2023 00:08
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants