Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX - 0.23.0 with node 8 crashes on start using dblite node module #5943

Closed
Blatman opened this issue Jun 1, 2017 · 6 comments
Closed

OSX - 0.23.0 with node 8 crashes on start using dblite node module #5943

Blatman opened this issue Jun 1, 2017 · 6 comments

Comments

@Blatman
Copy link

Blatman commented Jun 1, 2017

OSX 10.11.6 El Capitan

Have attached a test sample - 0.23.0 using node 8.0.0-pre crashes on start. The database seems to be accessed OK but then a FATAL occurs.
0.23.0 with node 7.10.0 works fine as do all prior builds.
The dblite module is a wrapper for the system installed sqlite3 - I was using the sqlite3 npm module but the dblite dev says not supported - must be system installed executable.

nwjs 0.23.0 - node v 7.10.0
http://dl.nwjs.io/live-build/05-26-2017/nw23-b56aac2-03b9af7-4a0cadc-f041292/v0.23.0/nwjs-sdk-v0.23.0-osx-x64.zip

nwjs 0.23.0 - node v 8.0.0pre
http://dl.nwjs.io/live-build/06-01-2017/nw23-b56aac2-bda2584-10a09e1-6fcfd63/v0.23.0/nwjs-sdk-v0.23.0-osx-x64.zip

crash0230withnode8.zip

dblite

@rogerwang
Copy link
Member

rogerwang commented Jun 1, 2017 via email

@Blatman
Copy link
Author

Blatman commented Jun 1, 2017

Not sure - I have only ever used dblite in the nwjs environment.
Cheers.

@Christywl
Copy link
Contributor

I can reproduce this issue on Mac with nwjs nightly build v0.23.0(nodejs v0.8.0), crash happens. nwjs v0.23.0(nodejs v0.7.10.0) works well.

I also write a js file with some codes from the reporter's sample(use 'dblite' module). Node v8.0.0 works well, no crash.

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next build.

@rogerwang
Copy link
Member

@Blatman
Copy link
Author

Blatman commented Jun 2, 2017

Corker - works fine, thanks guys.

wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Jan 18, 2018
- This case is failed on failed version 0.23.0, pass on fixed version 0.27.4
@wanghongjuan wanghongjuan self-assigned this Jan 18, 2018
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Jan 24, 2018
- This case is failed on failed version 0.23.0, pass on fixed version 0.27.4
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Jan 24, 2018
- This case is failed on failed version 0.23.0, pass on fixed version 0.27.4
rogerwang pushed a commit that referenced this issue Jan 29, 2018
- This case is failed on failed version 0.23.0, pass on fixed version 0.27.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants