[test] Add test for issue #5943 #6398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wanghongjuan
commented
Jan 18, 2018
•
wanghongjuan
commented
- Add test for issue OSX - 0.23.0 with node 8 crashes on start using dblite node module #5943
- This case is failed on failed version 0.23.0, pass on fixed version 0.27.4
rogerwang
requested changes
Jan 20, 2018
| pass | ||
|
|
||
| assert(False == os.path.isdir(node_module)) | ||
| subprocess.call(["npm", "install", "dblite"]) |
There was a problem hiding this comment.
installing modules for NW should have some environment variable set as: http://docs.nwjs.io/en/latest/For%20Users/Advanced/Use%20Native%20Node%20Modules/#for-non-lts-releases
Please see how the case 'native-module-buffer' is doing this.
There was a problem hiding this comment.
Updated the code
wanghongjuan
force-pushed
the
issue5943-add-test
branch
2 times, most recently
from
368a6d2 to
f2df591
Compare
- This case is failed on failed version 0.23.0, pass on fixed version 0.27.4
rogerwang
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.