Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go into an infinite-loop when the terminal crashes. #383

Closed
hymkor opened this issue May 3, 2020 · 3 comments
Closed

Go into an infinite-loop when the terminal crashes. #383

hymkor opened this issue May 3, 2020 · 3 comments
Assignees
@hymkor
Labels
bug

Comments

@hymkor
Copy link
Collaborator

hymkor commented May 3, 2020

.
@hymkor hymkor self-assigned this May 3, 2020
@hymkor hymkor added the bug label May 3, 2020
@hymkor
Copy link
Collaborator Author

hymkor commented May 3, 2020

It seems that :

  • The terminal(conhost.exe) crashes when Japanese words are typed on fzf
  • nyagos can not find it and continue running.

I consider that nyagos should quit as soon as the terminal ends not to be zombie !

@hymkor hymkor mentioned this issue May 3, 2020
Closed
hymkor added a commit that referenced this issue May 3, 2020
@hymkor
(#383) Fix: do not ignore the error that pipeline to terminal is disc…
d5ca8a4 
…onnected
@hymkor
Copy link
Collaborator Author

hymkor commented May 3, 2020

When terminal ended, the error go-tty.Open: No process is on the other end of the pipe. is recieved, but it is ignored.

I fixed it not to be ignored and to terminate nyagos.exe itself.

@hymkor
Copy link
Collaborator Author

hymkor commented May 3, 2020

hymkor added a commit that referenced this issue May 3, 2020
@hymkor
release_note*.md: wrote about #383
ec48859
@hymkor hymkor changed the title Crash or be zombie on searching Japanese words by fzf Go into an infinite-loop when the terminal crashes. May 3, 2020
@hymkor hymkor closed this as completed May 7, 2020
@hymkor hymkor mentioned this issue Mar 3, 2021
Closed
hymkor added a commit that referenced this issue Mar 31, 2024
@hymkor
Fix: the loop to input commands for foreach could not be stopped wi…
653a7cf 
…th Ctrl-C

( This problem was included in the commit 8bf0a2a of version 4.4.6_2. See also issue #383 and 4.4.6_0 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hymkor hymkor

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hymkor