Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"echo !xxx" causes unexpected end of nyagos. #402

Closed
masamitsu-murase opened this issue Mar 2, 2021 · 2 comments
Closed

"echo !xxx" causes unexpected end of nyagos. #402

masamitsu-murase opened this issue Mar 2, 2021 · 2 comments
Assignees
Labels

Comments

@masamitsu-murase
Copy link
Contributor

When I enter "echo !xxx" on nyagos, nyagos exits unexpectedly as follows:

$ echo !xxx
!xxx: event not found
exit status 1

I checked this issue with nyagos 4.4.9_3.

It seems that this issue is caused by d5ca8a4.
When Replace in history/history.go fails to replace !xxx in command line, the error is propagated to ForEver in shell/loop.go.
Then, the error ends for loop in ForEver in shell/loop.go.

@hymkor hymkor self-assigned this Mar 3, 2021
@hymkor hymkor added the bug label Mar 3, 2021
@hymkor
Copy link
Collaborator

hymkor commented Mar 3, 2021

Thank you.(ありがとうございます)

It seems that this issue is caused by d5ca8a4.

Right.

d5ca8a4 can not be reverted for #383 and other unexpected errors.
So, I fixed the called subroutine to display the error only but not to quit the shell on c3cae83

(そのとおりでした。とはいえ #383 や他の予期せぬエラーのために d5ca8a4 を消すわけにはいかないので、もっと下流の方で、ヒストリーのエラーを表示するだけにとどめておくよう修正しました)

hymkor added a commit that referenced this issue Mar 3, 2021
@masamitsu-murase
Copy link
Contributor Author

Thank you so much for your prompt response!
I verified that your fix, c3cae83, worked fine!

Let me close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants