Fixes compatibility with FeedMe's base FieldInterface #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a 500 error in the FeedMe mapping page when Recipe plugin is enabled, by adding return type declarations to getMappingTemplate and parseField methods to bring it back in line with FeedMe's base FieldInterface. This issue was occurring even if a recipe field was not in the field layout.
|
I very much appreciate the PR -- I think this was done from the wrong base, however. It should be done from |
|
Yeah I tried just switching the base, and it's somewhat of a mess. Could you redo the PR from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a 500 error in the FeedMe mapping page when Recipe plugin is enabled, by adding return type declarations to getMappingTemplate and parseField methods to bring it back in line with FeedMe's base FieldInterface. This issue was occurring even if a recipe field was not in the field layout.