Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compatibility with FeedMe's base FieldInterface #69

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

brandonjjon
Copy link
Contributor

Resolves a 500 error in the FeedMe mapping page when Recipe plugin is enabled, by adding return type declarations to getMappingTemplate and parseField methods to bring it back in line with FeedMe's base FieldInterface. This issue was occurring even if a recipe field was not in the field layout. With the correct base branch this time!

Resolves a 500 error in the FeedMe mapping page when Recipe plugin is enabled, by adding return type declarations to getMappingTemplate and parseField methods to bring it back in line with FeedMe's base FieldInterface. This issue was occurring even if a recipe field was not in the field layout.
@khalwat
Copy link
Contributor

khalwat commented Sep 29, 2023

Thank you so much!

@khalwat khalwat merged commit 6b1df4a into nystudio107:develop-v4 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants