Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCSDS TDM v 2.0 import/export #384

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

ChristopherRabotin
Copy link
Member

Summary

  • Add feature to read and write CCSDS TDM version 2, with aliases
  • Add feature to downsample tracking data using a low pass filter (sliding window average with decimation, which is an anti-aliasing filter)

Architectural Changes

  • Minor: Measurement now uses an IndexMap instead of a HashMap to store each measurement. This ensures consistent iteration, making the TDM file prettier.

New Features

  • Import/Export TDMs
  • Downsample tracking data using a low pass filter

Improvements

No change

Bug Fixes

No change

Testing and validation

  • Followed the Blue Book for the required fields
  • Ensure self-consistency in reading and writing the TDM file.

Documentation

This PR does not primarily deal with documentation changes.

…filter by tracker

I also noticed that the overlapping may no longer work with the new tracking data structure, so I added a warning.
Copy link

github-actions bot commented Dec 14, 2024

Visit the preview URL for this PR (updated for commit 442cc4f):

https://nyx-rustdoc--pr384-feat-gh-380-tdm-kvn-ek8qx1gv.web.app

(expires Sat, 21 Dec 2024 20:25:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d8e2a55934352d850c15d11866c39eb2d2e029be

@ChristopherRabotin
Copy link
Member Author

Plot of downsampled measurements

msr-range
msr-range-downsampled

msr-doppler
msr-dopper-downsampled

@ChristopherRabotin ChristopherRabotin linked an issue Dec 14, 2024 that may be closed by this pull request
2 tasks
@ChristopherRabotin ChristopherRabotin merged commit 12ad184 into master Dec 14, 2024
7 checks passed
@ChristopherRabotin ChristopherRabotin deleted the feat/gh-380-tdm-kvn-support branch December 14, 2024 21:29
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 26.39594% with 290 lines in your changes missing coverage. Please review.

Project coverage is 64.80%. Comparing base (16c4448) to head (442cc4f).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/od/msr/trackingdata/io_ccsds_tdm.rs 0.00% 224 Missing ⚠️
src/od/msr/trackingdata/mod.rs 54.86% 65 Missing ⚠️
src/od/simulator/arc.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   66.21%   64.80%   -1.41%     
==========================================
  Files          88       89       +1     
  Lines       13406    13677     +271     
==========================================
- Hits         8877     8864      -13     
- Misses       4529     4813     +284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CCSDS TDM in KVN format
1 participant