Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-568: Case snapshot isn't successful - Fixed #569

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

atarora
Copy link
Contributor

@atarora atarora commented Oct 17, 2022

The case snapshot feature facing some hiccups due to searchResults.js -> getNumfound method not returning value

Description

Removed the call to the method searchResults.js -> getNumfound() and returned the total numFound for the given query in the snapshot.

Motivation and Context

#568

How Has This Been Tested?

This has been tested by being able to create snapshot successfully and also use in the notebook feature

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh merged commit 6e5bfe4 into main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants