This repository has been archived by the owner on Oct 22, 2023. It is now read-only.
Updates for new rustc #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Sep 23, 2018
| @@ -368,12 +369,16 @@ fn to_block_id(id: EkidenBlockId) -> BlockId { | |||
| } | |||
| } | |||
|
|
|||
| pub fn to_bytes(num: u32) -> [u8; mem::size_of::<u32>()] { | |||
There was a problem hiding this comment.
unfortunate that this got removed. It looks like the deal is that they're moving to a to_le_bytes() API, but i guess the state at this nightly is that neither are stable?
Can you add a comment pointing to the language issue: rust-lang/rust#52963 so that we can get rid of this once .to_le_bytes is available?
|
I have a new PR coming up that fixes these bugs and more. |
|
Abandoned in favor of #199 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See oasisprotocol/oasis-core#970