This repository has been archived by the owner on Oct 22, 2023. It is now read-only.
Update runtime to use new rustc #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tf?
|
willscott
approved these changes
Sep 23, 2018
api/src/state.rs
Outdated
| @@ -30,15 +30,15 @@ pub struct Log { | |||
| pub transaction_log_index: Option<U256>, | |||
| } | |||
|
|
|||
| #[derive(Serialize, Deserialize, Debug)] | |||
| #[derive(Serialize, Deserialize, Debug, Clone)] | |||
There was a problem hiding this comment.
What changed that makes us need Clone?
There was a problem hiding this comment.
error[E0277]: the trait bound `ethereum_api::AccountState: std::clone::Clone` is not satisfied
--> src/lib.rs:109:1
|
109 | / with_api! {
110 | | create_contract_client!(runtime_ethereum, ethereum_api, api);
111 | | }
| |_^ the trait `std::clone::Clone` is not implemented for `ethereum_api::AccountState`
|
= note: required because of the requirements on the impl of `std::clone::Clone` for `std::vec::Vec<ethereum_api::AccountState>`
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
There was a problem hiding this comment.
Weird, this build worked fine without it: https://circleci.com/gh/oasislabs/runtime-ethereum/1436
There was a problem hiding this comment.
What changed that makes us need Clone?
No idea. I just do what cargo tells me to do.
error[E0277]: the trait bound `ethereum_api::AccountState: std::clone::Clone` is not satisfied
--> src/lib.rs:109:1
|
109 | / with_api! {
110 | | create_contract_client!(runtime_ethereum, ethereum_api, api);
111 | | }
| |_^ the trait `std::clone::Clone` is not implemented for `ethereum_api::AccountState`
= note: you can solve this by selling your soul to the Rust developers
There was a problem hiding this comment.
I'll see if I can revert and rebuild.
There was a problem hiding this comment.
nope. still getting the error
|
Yep, |
|
IDK what's going on with |
|
Also can remove |
peterjgilbert
approved these changes
Sep 23, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#198 but with a bit extra to keep the gateway happy