fix: update Android react-native resolution approach in monorepos
#714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
Feb 10, 2025
### Description Update `react-native-keychain` to a divvi fork. It includes the patch included in the replaced intera fork, and a new [Android build fix](oblador/react-native-keychain#714) addressing the [build issue](https://github.com/divvixyz/divvi-mobile/actions/runs/13204494837/job/36864355193?pr=70) in the divvi mobile monorepo. Full diff with the original package: oblador/react-native-keychain@master...mobilestack-xyz:react-native-keychain:divvi-fork ### TODO Migrate to the original package once these PRs are included: * oblador/react-native-keychain#712 * oblador/react-native-keychain#714 ### Test plan CI ### Related issues - Related to RET-1308 ### Backwards compatibility Y ### Network scalability NA
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
Feb 10, 2025
### Description Update `react-native-keychain` to a divvi fork. It includes the patch included in the replaced intera fork, and a new [Android build fix](oblador/react-native-keychain#714) addressing the [build issue](https://github.com/divvixyz/divvi-mobile/actions/runs/13204494837/job/36864355193?pr=70) in the divvi mobile monorepo. Full diff with the original package: oblador/react-native-keychain@master...mobilestack-xyz:react-native-keychain:divvi-fork ### TODO Migrate to the original package once these PRs are included: * oblador/react-native-keychain#712 * oblador/react-native-keychain#714 ### Test plan CI ### Related issues - Related to RET-1308 ### Backwards compatibility Y ### Network scalability NA
|
@bakoushin Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the React Native package resolution in Android for monorepos, aligning with the recent approach used in
react-native-reanimated.Rationale
This update introduces a nesting-agnostic resolution approach, making it more adaptable to various monorepo structures. Different projects organize their repositories with varying levels of nesting. For example, in the
@divvy/mobileframework, apps are structured within the/appsdirectory rather than at the root. This change ensures better compatibility across different monorepos.