Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update react-native-keychain to divvi fork #6488

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

bakoushin
Copy link
Contributor

@bakoushin bakoushin commented Feb 10, 2025

Description

Update react-native-keychain to a divvi fork. It includes the patch included in the replaced intera fork, and a new Android build fix addressing the build issue in the divvi mobile monorepo.

Full diff with the original package:
oblador/react-native-keychain@master...mobilestack-xyz:react-native-keychain:divvi-fork

TODO

Migrate to the original package once these PRs are included:

Test plan

CI

Related issues

Backwards compatibility

Y

Network scalability

NA

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.06%. Comparing base (1237acd) to head (0bfc67e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #6488    +/-   ##
========================================
  Coverage   89.06%   89.06%            
========================================
  Files         729      729            
  Lines       31848    31848            
  Branches     5816     6138   +322     
========================================
  Hits        28365    28365            
+ Misses       3435     3285   -150     
- Partials       48      198   +150     
Files with missing lines Coverage Δ
src/app/actions.ts 94.36% <ø> (ø)
src/app/reducers.ts 26.82% <ø> (ø)
src/app/saga.ts 70.95% <100.00%> (ø)
src/onboarding/registration/EnableBiometry.tsx 100.00% <100.00%> (ø)
src/onboarding/steps.ts 95.08% <ø> (ø)
src/pincode/PincodeSet.tsx 94.39% <ø> (ø)
src/pincode/authentication.ts 87.24% <100.00%> (ø)
src/storage/keychain.tsx 88.63% <100.00%> (ø)
test/mockedKeychain.ts 100.00% <100.00%> (ø)

... and 63 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1237acd...0bfc67e. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bakoushin bakoushin added this pull request to the merge queue Feb 10, 2025
@bakoushin bakoushin removed this pull request from the merge queue due to a manual request Feb 10, 2025
@bakoushin bakoushin added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit c1c8643 Feb 10, 2025
15 checks passed
@bakoushin bakoushin deleted the alex/update-react-native-keychain branch February 10, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants