-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode Variant selectors on some emojis work, while others are parsed incorrectly #3179
Comments
Thanks for logging the issue.
|
Can you please be more specific than that. What exact emoji picker did you use? |
Why would an emoji picker need to add a variant? What is going on here? |
I don't know exactly why the emoji picker added a variant selector on, but over half the emojis I regularly use multiple several Unicode characters instead of one. I'm guessing it's to ensure that the emojis are displayed in color instead of text mode in some applications. Emote is the picker I'm using to enter emojis. |
Do you mean We had a similar issue #2273 which was solved, but it looks like the fix covered only the priority selector, not the other icons. |
Hi @techy-robot and @Cito, Thank you both for pointing out the link to #2273. Obviously this issue changes that, and a more general solution is now required. I've added the |
Reopening. |
This time it is really fixed - and with some earlier refactorings, the code is less repetitive and easier to maintain too. Thanks again for reporting it, @techy-robot. I have to write some docs for a new feature before I can do the next release. So I'll leave a note here when the release is done... |
Just released in Tasks 7.14.0 - Enjoy! |
Please check that this issue hasn't been reported before.
Steps to reproduce
Result:
Recognized:
- [ ] test ⏳ 2024-11-18
, Not recognized:- [ ] test ⏳️ 2024-11-18
Expected Behavior
Tasks should ignore emoji variants like what is described in #2273, except on all emojis. Emoji variants should have no effect on its parsing behavior.
Current behaviour
Currently, Tasks ignores the variant selector on the priority arrows (a previous issue), however it does not ignore it on other emojis like Scheduled. The solution appears to be focused on a specific emoji case, when really it can show up in all emojis. I was initially confused as to why tasks wouldn't show up using a filter, until I played around with different methods of getting the emoji and realized that it must be a variant selector. Sure enough, I was getting
\ufe0f\u23f3
on the hour glass emoji that didn't work, and just\ufe0f
on the one that did.Which Operating Systems are you using?
Obsidian Version
1.6.7
Tasks Plugin Version
7.13.0
Checks
Possible solution
Implement a solution similar to #2695, except ignoring variant selectors in all emojis.
The text was updated successfully, but these errors were encountered: