Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow multiple spaces after onCompletion emoji #3191

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented Nov 21, 2024

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Multiple spaces are now allowed between 🏁 and its value.

I found this whilst doing preparatory refactoring to fix #3179.

Also, adjust test to confirm that parsing of on completion field is case-insensitive.

Motivation and Context

Fix unreported bug that the Tasks Emoji format did not allow more than one space between the emoji and value.

  • 🏁 delete worked
  • 🏁 delete was not parsed, and was considered part of the task description

How has this been tested?

  • Added failing test to show the problem
  • Did exploratory testing to confirm it's fixed

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

@claremacrae claremacrae added scope: parsing markdown See also 'scope: global filter' scope: lifecycle of tasks Issues to do with deletion or moving of tasks upon completion. See also 'scope: managing tasks' labels Nov 21, 2024
@claremacrae claremacrae merged commit cae0faf into main Nov 21, 2024
3 checks passed
@claremacrae claremacrae deleted the fix-on-completion-parsing branch November 21, 2024 10:15
@claremacrae claremacrae changed the title fix: - Allow multiple spaces after onCompletion emoji fix: Allow multiple spaces after onCompletion emoji Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: lifecycle of tasks Issues to do with deletion or moving of tasks upon completion. See also 'scope: managing tasks' scope: parsing markdown See also 'scope: global filter'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode Variant selectors on some emojis work, while others are parsed incorrectly
1 participant