fix: Allow multiple spaces after onCompletion emoji #3191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
fix
- non-breaking change which fixes an issue)Internal changes:
test
- additions and improvements to unit tests and the smoke tests)Description
Multiple spaces are now allowed between
🏁
and its value.I found this whilst doing preparatory refactoring to fix #3179.
Also, adjust test to confirm that parsing of
on completion
field is case-insensitive.Motivation and Context
Fix unreported bug that the Tasks Emoji format did not allow more than one space between the emoji and value.
🏁 delete
worked🏁 delete
was not parsed, and was considered part of the task descriptionHow has this been tested?
Checklist
yarn run lint
.Terms