Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a function for a known set of working overrides #16

Closed
wants to merge 5 commits into from

Conversation

@3noch 3noch requested a review from luigy August 31, 2018 17:30
@3noch
Copy link
Collaborator Author

3noch commented Aug 31, 2018

We need more instances for ToJSONKey/FromJSONKey as reported by @luigy. However, the instances needed depend on use case so they shouldn't necessarily block this PR. But I wouldn't be opposed to adding more now.

@luigy
Copy link
Collaborator

luigy commented Aug 31, 2018

@3noch ended adding support for it here b905fa3

Though I wonder if something like haskell/aeson#463 will bite us assuming it is still relevant

@3noch
Copy link
Collaborator Author

3noch commented Sep 1, 2018

Oh nice!

Interesting. That issue is oddly quiet...

@3noch 3noch mentioned this pull request Sep 14, 2018
@danbornside danbornside mentioned this pull request Oct 9, 2018
@3noch
Copy link
Collaborator Author

3noch commented Nov 21, 2018

@luigy Anything else waiting for this?

@ali-abrar
Copy link
Member

There are some conflicts. What else do we need to do to merge this?

@3noch
Copy link
Collaborator Author

3noch commented Jan 25, 2019

@ali-abrar I believe @matthewbauer is completely revamping this in #27.

@ali-abrar
Copy link
Member

Alright, please close it that's the case

@ali-abrar ali-abrar closed this Jan 25, 2019
@3noch
Copy link
Collaborator Author

3noch commented Jan 25, 2019

@ali-abrar I'm not actually sure what #27 is for.

@ali-abrar ali-abrar deleted the db-fix-build-errors branch November 20, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants