Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tezos reunification #22

Merged
merged 43 commits into from
Jan 26, 2019
Merged

Tezos reunification #22

merged 43 commits into from
Jan 26, 2019

Conversation

danbornside
Copy link
Contributor

@danbornside danbornside commented Oct 9, 2018

This is on top of both #16 and #17

danbornside and others added 30 commits August 15, 2018 17:10
This is incompatible with the older reflex-platform this is being
switched to.
This allows to customize the cookie like setting a path for it.
structured arrays so that future additions don't break existing configs.
@ali-abrar
Copy link
Member

This has been open for a long time. How can we get this merged? Are there any breaking changes?

@3noch
Copy link
Collaborator

3noch commented Jan 25, 2019

@ali-abrar This includes the same changes from #25 so we'll have to at least deal with those conflicts. Also #27 is built on top of this?

@Ericson2314
Copy link
Member

Ericson2314 commented Jan 26, 2019

Yes #27 includes all of this but my last commit to use aeon-gadt-th. Since that is conceptually separate, but depend on the Nix code changes in here, I'd turn this into a PR for just that and deem it blocked on #27 so we just re-review this once it becomes a small 1-commit PR.

@ali-abrar ali-abrar merged commit 5a529a0 into master Jan 26, 2019
@ali-abrar ali-abrar deleted the tezos-reunification branch November 20, 2021 19:00
ryantrinkle pushed a commit that referenced this pull request Sep 24, 2024
) from jg/use-subtransactions-for-snapshot-protection into master

Reviewed-on: https://code.obsidian.systems/rhyolite/rhyolite/pulls/22
Reviewed-by: ryantrinkle <[email protected]>
Reviewed-by: Cale Gibbard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants