-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add journald logging datatypes on non-Linux #37
Conversation
These need to be available in some cases.
This is needed for release.nix to properly build things on another system.
Can we just use #7 instead? |
IIRC depending on journald in cabal prevents mac support so using a cabal flag as #7 does allows you to choose this at the dependency level. |
I don't see how introducing a cabal flag improves the situation besides making things more confusing. The issue was introduced in 345a0e2. I guess it's debatable whether it should be a runtime error or a type error though... But if it's a runtime error, this is needed to get things working again. |
Are users ever expected to write code that uses this constructor? If so, I'd rather not force CPP into user code, but if not we can revert 345a0e2 and replace with another approach. |
Haha we've implemented the same thing multiple times! |
Closing in favor of #38 |
These need to be available in some cases.