systemd again #38
Merged
systemd again #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/develop: Deprecate Rhyolite.Frontend.Request Remove some json decoding code that's been upstreamed to Reflex.Dom Use postgresql-lo-stream Remove some old stuff from Rhyolite.Frontend.Request
…turl * origin/develop: Deprecate Rhyolite.Frontend.Request Remove some json decoding code that's been upstreamed to Reflex.Dom Use postgresql-lo-stream Remove some old stuff from Rhyolite.Frontend.Request
…o aa-remove-websocketurl * origin/db-WIP-dont-force-groundhog:
ali-abrar
changed the base branch from
develop
to
db-WIP-dont-force-groundhog
ali-abrar
force-pushed
the
aa-systemd-take-10
branch
from
0d1f801 to
e7e78e4
Compare
|
also brings |
|
tested on macOS and linux |
|
I think we need examples of how you are supposed to use Rhyolite with this new flag. For instance if you have os = linux and support-systemd-journal = false, how do you write code to detect that? Is there a way to get that CPP definition in your code? Anyone using rhyolite has to worry about that case now. That’s why I think it makes sense to have all Linux support systemd… It doesn’t require you actually run systemd anyway, just that rhyolite was built with the systemd library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.