Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml 4.02.3: internal error raised from Exn.Code_error #1736

Closed
avsm opened this issue Jan 4, 2019 · 10 comments · Fixed by ocaml/opam-repository#13444
Closed

ocaml 4.02.3: internal error raised from Exn.Code_error #1736

avsm opened this issue Jan 4, 2019 · 10 comments · Fixed by ocaml/opam-repository#13444
Assignees

Comments

@avsm
Copy link
Member

avsm commented Jan 4, 2019

In the ctypes build of the dune port, 4.02.3 is specifically raising some internal errors in dune that aren't happening on later versions of the compiler. Sadly, 4.02.3 is still one of the support compiler versions so we need to worry about it :-)

See https://travis-ci.com/avsm/ocaml-ctypes/jobs/168302505 for a full run. The tree that is exhibiting the problem is in https://github.com/avsm/ocaml-ctypes/tree/dune-port and tracked as a PR in yallop/ocaml-ctypes#588

- /-----------------------------------------------------------------------
- | Internal error: Fiber.Execution_context.forward_error: error handler raised.
- | Stdune__Exn.Code_error(_)
- | Called from file "camlinternalLazy.ml", line 25, characters 17-27
- | Re-raised at file "camlinternalLazy.ml", line 32, characters 10-11
- | Called from file "src/errors.ml", line 77, characters 17-47
- | Called from file "format.ml", line 1175, characters 28-44
- | Called from file "src/stdune/option.ml", line 23, characters 14-17
- | Called from file "src/fiber/fiber.ml", line 243, characters 6-18
- | Called from file "src/fiber/fiber.ml", line 56, characters 6-20
- | 
- | Original exception was: Stdune__Exn.Code_error(_)
- | Called from file "camlinternalLazy.ml", line 25, characters 17-27
- | Re-raised at file "camlinternalLazy.ml", line 32, characters 10-11
- | Called from file "src/errors.ml", line 77, characters 17-47
- | Called from file "format.ml", line 1175, characters 28-44
- | Called from file "src/stdune/option.ml", line 23, characters 14-17
- | Called from file "src/fiber/fiber.ml", line 243, characters 6-18
- \-----------------------------------------------------------------------
@rgrinberg
Copy link
Member

Sadly, this seems to be a sandboxing issue that I can't reproduce on OSX. What's even more strange that I couldn't reproduce it in one of your docker images either (with pinning). I'll see if I can produce a branch that will improve the error messages in this case.

@rgrinberg
Copy link
Member

@avsm would you mind running this again against #1739 ?

This should give us a better error message. Sorry for the trouble, but I can't reproduce locally.

avsm added a commit to avsm/ocaml-ctypes that referenced this issue Jan 5, 2019
@avsm
Copy link
Member Author

avsm commented Jan 7, 2019

Hm this is with the pin now successfully in place, but no more extra output as far as I can tell https://travis-ci.org/ocamllabs/ocaml-ctypes/jobs/476067840#L657

@ghost
Copy link

ghost commented Jan 7, 2019

Maybe the exception printer is raising? Exceptions raised by exception printers are silently ignored by Printexc.to_string.

@rgrinberg
Copy link
Member

Okay, I think I found the error. Will post a fix shortly.

@avsm
Copy link
Member Author

avsm commented Jan 8, 2019

Hm, I still see the same error with a pin to latest dune master:
https://travis-ci.org/ocamllabs/ocaml-ctypes/jobs/476974038

- /-----------------------------------------------------------------------
- | Internal error: Fiber.Execution_context.forward_error: error handler raised.
- | Stdune__Exn.Code_error(_)
- | Called from file "camlinternalLazy.ml", line 25, characters 17-27
- | Re-raised at file "camlinternalLazy.ml", line 32, characters 10-11
- | Called from file "src/errors.ml", line 77, characters 17-47
- | Called from file "format.ml", line 1175, characters 28-44
- | Called from file "src/stdune/option.ml", line 23, characters 14-17
- | Called from file "src/fiber/fiber.ml", line 56, characters 6-20
- | 
- | Original exception was: Stdune__Exn.Code_error(_)
- | Called from file "camlinternalLazy.ml", line 25, characters 17-27
- | Re-raised at file "camlinternalLazy.ml", line 32, characters 10-11
- | Called from file "src/errors.ml", line 77, characters 17-47
- | Called from file "format.ml", line 1175, characters 28-44
- | Called from file "src/stdune/option.ml", line 23, characters 14-17
- | Called from file "src/fiber/fiber.ml", line 243, characters 6-18
- \-----------------------------------------------------------------------

@avsm
Copy link
Member Author

avsm commented Jan 8, 2019

I just noticed that it seems to happen in dune subst, not dune build

@avsm avsm reopened this Jan 8, 2019
@rgrinberg
Copy link
Member

You probably forgot to update things. Line 77 in errors.ml doesn't exist anymore.

@avsm
Copy link
Member Author

avsm commented Jan 9, 2019

Argh, it's because opam pin -n with a pin depends doesn't actually install the updated dune without an opam upgrade. Sorry...

@avsm avsm closed this as completed Jan 9, 2019
@avsm
Copy link
Member Author

avsm commented Jan 9, 2019

And 4.02.3 is now compiling and running fine in ctypes CI. Hurrah!

rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Feb 12, 2019
CHANGES:

- Second step of the deprecation of jbuilder: the `jbuilder` binary
  now emits a warning on every startup and both `jbuilder` and `dune`
  emit warnings when encountering `jbuild` files (ocaml/dune#1752, @diml)

- Change the layout of build artifacts inside _build. The new layout enables
  optimizations that depend on the presence of `.cmx` files of private modules
  (ocaml/dune#1676, @bobot)

- Fix merlin handling of private module visibility (ocaml/dune#1653 @bobot)

- unstable-fmt: use boxes to wrap some lists (ocaml/dune#1608, fix ocaml/dune#1153, @emillon,
  thanks to @rgrinberg)

- skip directories when looking up programs in the PATH (ocaml/dune#1628, fixes
  ocaml/dune#1616, @diml)

- Use `lsof` on macOS to implement `--stats` (ocaml/dune#1636, fixes ocaml/dune#1634, @xclerc)

- Generate `dune-package` files for every package. These files are installed and
  read instead of `META` files whenever they are available (ocaml/dune#1329, @rgrinberg)

- Fix preprocessing for libraries with `(include_subdirs ..)` (ocaml/dune#1624, fix ocaml/dune#1626,
  @nojb, @rgrinberg)

- Do not generate targets for archive that don't match the `modes` field.
  (ocaml/dune#1632, fix ocaml/dune#1617, @rgrinberg)

- When executing actions, open files lazily and close them as soon as
  possible in order to reduce the maximum number of file descriptors
  opened by Dune (ocaml/dune#1635, ocaml/dune#1643, fixes ocaml/dune#1633, @jonludlam, @rgrinberg,
  @diml)

- Reimplement the core of Dune using a new generic memoization system
  (ocaml/dune#1489, @rudihorn, @diml)

- Replace the broken cycle detection algorithm by a state of the art
  one from [this paper](https://doi.org/10.1145/2756553) (ocaml/dune#1489,
  @rudihorn)

- Get the correct environment node for multi project workspaces (ocaml/dune#1648,
  @rgrinberg)

- Add `dune compute` to call internal memoized functions (ocaml/dune#1528,
  @rudihorn, @diml)

- Add `--trace-file` option to trace dune internals (ocaml/dune#1639, fix ocaml/dune#1180, @emillon)

- Add `--no-print-directory` (borrowed from GNU make) to suppress
  `Entering directory` messages. (ocaml/dune#1668, @dra27)

- Remove `--stats` and track fd usage in `--trace-file` (ocaml/dune#1667, @emillon)

- Add virtual libraries feature and enable it by default (ocaml/dune#1430 fixes ocaml/dune#921,
  @rgrinberg)

- Fix handling of Control+C in watch mode (ocaml/dune#1678, fixes ocaml/dune#1671, @diml)

- Look for jsoo runtime in the same dir as the `js_of_ocaml` binary
  when the ocamlfind package is not available (ocaml/dune#1467, @nojb)

- Make the `seq` package available for OCaml >= 4.07 (ocaml/dune#1714, @rgrinberg)

- Add locations to error messages where a rule fails to generate targets and
  rules that require files outside the build/source directory. (ocaml/dune#1708, fixes
  ocaml/dune#848, @rgrinberg)

- Let `Configurator` handle `sizeof` (in addition to negative numbers).
  (ocaml/dune#1726, fixes ocaml/dune#1723, @Chris00)

- Fix an issue causing menhir generated parsers to fail to build in
  some cases. The fix is to systematically use `-short-paths` when
  calling `ocamlc -i` (ocaml/dune#1743, fix ocaml/dune#1504, @diml)

- Never raise when printing located errors. The code that would print the
  location excerpts was prone to raising. (ocaml/dune#1744, fix ocaml/dune#1736, @rgrinberg)

- Add a `dune upgrade` command for upgrading jbuilder projects to Dune
  (ocaml/dune#1749, @diml)

- When automatically creating a `dune-project` file, insert the
  detected name in it (ocaml/dune#1749, @diml)

- Add `(implicit_transitive_deps <bool>)` mode to dune projects. When this mode
  is turned off, transitive dependencies are not accessible. Only listed
  dependencies are directly accessible. (ocaml/dune#1734, ocaml/dune#430, @rgrinberg, @hnrgrgr)

- Add `toplevel` stanza. This stanza is used to define toplevels with libraries
  already preloaded. (ocaml/dune#1713, @rgrinberg)

- Generate `.merlin` files that account for normal preprocessors defined using a
  subset of the `action` language. (ocaml/dune#1768, @rgrinberg)

- Emit `(orig_src_dir <path>)` metadata in `dune-package` for dune packages
  built with `--store-orig-source-dir` command line flag (also controlled by
  `DUNE_STORE_ORIG_SOURCE_DIR` env variable). This is later used to generate
  `.merlin` with `S`-directives pointed to original source locations and thus
  allowing merlin to see those. (ocaml/dune#1750, @andreypopp)

- Improve the behavior of `dune promote` when the files to be promoted have been
  deleted. (ocaml/dune#1775, fixes ocaml/dune#1772, @diml)

- unstable-fmt: preserve comments (ocaml/dune#1766, @emillon)

- Pass flags correctly when using `staged_pps` (ocaml/dune#1779, fixes ocaml/dune#1774, @diml)

- Fix an issue with the use of `(mode promote)` in the menhir
  stanza. It was previously causing intermediate *mock* files to be
  promoted (ocaml/dune#1783, fixes ocaml/dune#1781, @diml)

- unstable-fmt: ignore files using OCaml syntax (ocaml/dune#1784, @emillon)

- Configurator: Add `which` function to replace the `which` command line utility
  in a cross platform way. (ocaml/dune#1773, fixes ocaml/dune#1705, @Chris00)

- Make configurator append paths to `$PKG_CONFIG_PATH` on macOS. Previously it
  was prepending paths and thus `$PKG_CONFIG_PATH` set by users could have been
  overridden by homebrew installed libraries (ocaml/dune#1785, @andreypopp)

- Disallow c/cxx sources that share an object file in the same stubs archive.
  This means that `foo.c` and `foo.cpp` can no longer exist in the same library.
  (ocaml/dune#1788, @rgrinberg)

- Forbid use of `%{targets}` (or `${@}` in jbuild files) inside
  preprocessing actions
  (ocaml/dune#1812, fixes ocaml/dune#1811, @diml)

- Add `DUNE_PROFILE` environment variable to easily set the profile. (ocaml/dune#1806,
  @rgrinberg)

- Deprecate the undocumented `(no_keep_locs)` field. It was only
  necessary until virtual libraries were supported (ocaml/dune#1822, fix ocaml/dune#1816,
  @diml)

- Rename `unstable-fmt` to `format-dune-file` and remove its `--inplace` option.
  (ocaml/dune#1821, @emillon).

- Autoformatting: `(using fmt 1.1)` will also format dune files (ocaml/dune#1821, @emillon).

- Autoformatting: record dependencies on `.ocamlformat-ignore` files (ocaml/dune#1824,
  fixes ocaml/dune#1793, @emillon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants