Improve printing of fatal errors #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2019
rgrinberg
force-pushed
the
always-print-exn
branch
from
acf30e5 to
179dbd7
Compare
avsm
added a commit
to avsm/ocaml-ctypes
that referenced
this pull request
Jan 5, 2019
emillon
approved these changes
Jan 7, 2019
ghost
approved these changes
Jan 7, 2019
rgrinberg
force-pushed
the
always-print-exn
branch
from
179dbd7 to
3edc9a9
Compare
Currently, some fatal errors aren't printed because things fail before the printers are all registered. This PR registers the printers as early as possible. This way, all exceptions are properly printed. Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
always-print-exn
branch
from
3edc9a9 to
f61fd37
Compare
|
@emillon I moved excerpt printing to the Loc module as well. It's bound to be useful in other places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some fatal errors aren't printed because things fail before the
printers are all registered. This PR registers the printers as early as
possible. This way, all exceptions are properly printed.
Signed-off-by: Rudi Grinberg [email protected]