Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement [dune cache] command #4471

Closed
snowleopard opened this issue Apr 9, 2021 · 0 comments · Fixed by #6614
Closed

Reimplement [dune cache] command #4471

snowleopard opened this issue Apr 9, 2021 · 0 comments · Fixed by #6614
Assignees
@snowleopard
Labels
shared-cache Shared artefacts cache

Comments

@snowleopard
Copy link
Collaborator

This is a reminder to myself to reimplement the dune cache command using command groups, and to mark dune cache start and dune cache stop commands as deprecated.

Blocked by #4467.
@snowleopard snowleopard self-assigned this Apr 9, 2021
@rgrinberg rgrinberg added the shared-cache Shared artefacts cache label May 19, 2022
Alizter added a commit to Alizter/dune that referenced this issue Dec 1, 2022
@Alizter
refactor(cache): use cmdliner groups in dune cache commands
cf1bfdc 
We also do some cleanup of the documentation. This will make adding
more subcommands easier in the future.

closes ocaml#4471

Signed-off-by: Ali Caglayan <[email protected]>

<!-- ps-id: 60b331a0-d183-498b-9bba-5ea3d4538fb2 -->
@Alizter Alizter mentioned this issue Dec 1, 2022
Merged
Alizter added a commit to Alizter/dune that referenced this issue Dec 2, 2022
@Alizter
refactor(cache): use cmdliner groups in dune cache commands
ea65cea 
We also do some cleanup of the documentation. This will make adding
more subcommands easier in the future.

closes ocaml#4471

<!-- ps-id: 60b331a0-d183-498b-9bba-5ea3d4538fb2 -->

Signed-off-by: Ali Caglayan <[email protected]>
Alizter added a commit to Alizter/dune that referenced this issue Dec 4, 2022
@Alizter
refactor(cache): use cmdliner groups in dune cache commands
df9bc09 
We also do some cleanup of the documentation. This will make adding
more subcommands easier in the future.

closes ocaml#4471

<!-- ps-id: 60b331a0-d183-498b-9bba-5ea3d4538fb2 -->

Signed-off-by: Ali Caglayan <[email protected]>
Alizter added a commit to Alizter/dune that referenced this issue Dec 4, 2022
@Alizter
refactor(cache): use cmdliner groups in dune cache commands
1eaabdd 
We also do some cleanup of the documentation. This will make adding
more subcommands easier in the future.

closes ocaml#4471

<!-- ps-id: 60b331a0-d183-498b-9bba-5ea3d4538fb2 -->

Signed-off-by: Ali Caglayan <[email protected]>
Alizter added a commit to Alizter/dune that referenced this issue Dec 5, 2022
@Alizter
refactor(cache): use cmdliner groups in dune cache commands
a01488a 
We also do some cleanup of the documentation. This will make adding
more subcommands easier in the future.

closes ocaml#4471

<!-- ps-id: 60b331a0-d183-498b-9bba-5ea3d4538fb2 -->

Signed-off-by: Ali Caglayan <[email protected]>
Alizter added a commit that referenced this issue Dec 5, 2022
@Alizter
refactor(cache): use cmdliner groups in dune cache commands
0a66f65 
We also do some cleanup of the documentation. This will make adding
more subcommands easier in the future.

closes #4471

<!-- ps-id: 60b331a0-d183-498b-9bba-5ea3d4538fb2 -->

Signed-off-by: Ali Caglayan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snowleopard snowleopard

Labels
shared-cache Shared artefacts cache
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(cache): use cmdliner groups in dune cache commands Alizter/dune
2 participants
@rgrinberg @snowleopard