refactor(cache): use cmdliner groups in dune cache commands #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
commented
Dec 1, 2022
Alizter
force-pushed
the
ps/rr/refactor_cache___use_cmdliner_groups_in_dune_cache_commands
branch
from
cf1bfdc to
ea65cea
Compare
snowleopard
reviewed
Dec 4, 2022
snowleopard
reviewed
Dec 4, 2022
snowleopard
reviewed
Dec 4, 2022
|
@snowleopard I've made #6632 which I will rebase this on so you can see the diff easier. |
Sounds good, thanks! |
Alizter
force-pushed
the
ps/rr/refactor_cache___use_cmdliner_groups_in_dune_cache_commands
branch
2 times, most recently
from
df9bc09 to
1eaabdd
Compare
snowleopard
reviewed
Dec 5, 2022
snowleopard
approved these changes
Dec 5, 2022
We also do some cleanup of the documentation. This will make adding more subcommands easier in the future. closes ocaml#4471 <!-- ps-id: 60b331a0-d183-498b-9bba-5ea3d4538fb2 --> Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
ps/rr/refactor_cache___use_cmdliner_groups_in_dune_cache_commands
branch
from
0eab71e to
a01488a
Compare
Alizter
deleted the
ps/rr/refactor_cache___use_cmdliner_groups_in_dune_cache_commands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also do some cleanup of the documentation. This will make adding more subcommands easier in the future.
The (deprecated and removed) commands start and stop have also been completely removed.
closes #4471
Signed-off-by: Ali Caglayan [email protected]