Don't allow for private dependencies in public libraries #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating the META file, make sure all the requires fields point to public dependencies. If not, then error out.
|
I think it is indeed too late to throw the error and as a result we can't point the error to the right place in the jbuild file. I think we should instead implement this check in the |
|
Fixed in #607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the META file, make sure all the requires fields point to public
dependencies. If not, then error out.
The main thing here that I'm not sure about is if this is the right time to throw this error. It seems like we can raise it much earlier.
Regardless, it would be really nice to properly address this with strict libraries.