Disallow public/private overlap #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag to guard public dependencies from acquiring private ones
Those will go in their own test
Closed
rgrinberg
force-pushed
the
private-public-overlap-take2
branch
from
10a01b9 to
753badd
Compare
ghost
approved these changes
Mar 12, 2018
|
Looks good. I pushed a couple of minor changes. BTW the locations looks wrong in the tests, there must be a problem somewhere. It's not specific to this PR though. |
|
The location issue was fixed in #609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok @diml, the flag approach works well here. The only issue is that I don't know how to retrieve the name of the public dependency that's requiring the private dependency in the error message.