Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(melange): show work around for ocamldep issue + melange ppx #7321

Closed

Conversation

anmonteiro
Copy link
Collaborator

This is an alternative version of #6625 with a workaround that's not manual.

Right now it's possible to overcome the limitation of ocamldep running before the melange PPX by:

  • adding a (preprocess (action melc --as-ppx %{input-file})) field

This, however, has a pretty significant limitation: it isn't possible to run both actions + ppxes in a preprocess field (see #171).

So, it sounds to me that we need to solve this in melange too:

@jchavarri
Copy link
Collaborator

@anmonteiro I believe this can be closed now?

@jchavarri
Copy link
Collaborator

ref: #7323 (comment)

@anmonteiro
Copy link
Collaborator Author

Indeed this can be closed. We added tests in melange for this case.

@anmonteiro anmonteiro closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
melange Melange rules and generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants