melange: add test to reproduce "inconsistent assumptions" issue when using melange ppx #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Chávarri <[email protected]>
jchavarri
force-pushed
the
melange/repro-lib-cmi-inconsistent-assumptions
branch
from
de1ba76 to
6bc6360
Compare
Signed-off-by: Javier Chávarri <[email protected]>
|
Added showcase of a fix using @anmonteiro workaround from #7321: ba30e9b |
1 task
1 task
|
Is there any value on keeping this test around? |
|
no, we added it in melange. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6625.
Found recently another error that is related to the Melange ppx, in this case, considering a sufficiently complex dep tree between modules, changing a leaf in the dep tree leads to inconsistencies on how inner modules see the cmis.
I can merge this PR into #6625 if it makes things easier.