Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove git cache objects that may be used #3831

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Don't remove git cache objects that may be used #3831

merged 1 commit into from
Apr 23, 2019

Conversation

AltGr
Copy link
Member

@AltGr AltGr commented Apr 19, 2019

This is a quickfix, we can probably do better than that ; see #3828

@AltGr
Don't remove git cache objects that may be used
8b610f0 
This is a quickfix, we can probably do better than that ; see ocaml#3828
@AltGr AltGr merged commit cfd5c5e into ocaml:master Apr 23, 2019
erikmd added a commit to math-comp/docker-mathcomp that referenced this pull request Jun 6, 2019
@erikmd
Don't clear $OPAMROOT/download-cache from coqorg/coq:dev
75c0f53 
This patch will be unnecessary when PR ocaml/opam#3831 is released.
@rjbou rjbou added this to the 2.1.0 milestone Jun 12, 2019
erikmd added a commit to math-comp/docker-mathcomp that referenced this pull request Jul 27, 2019
@erikmd
Don't clear $OPAMROOT/download-cache from coqorg/coq:dev
105d9b9 
This patch will be unnecessary when PR ocaml/opam#3831 is released.
erikmd added a commit to math-comp/docker-mathcomp that referenced this pull request Jul 29, 2019
@erikmd
Don't clear $OPAMROOT/download-cache from coqorg/coq:dev
8491df0 
This patch will be unnecessary when PR ocaml/opam#3831 is released.
erikmd added a commit to math-comp/docker-mathcomp that referenced this pull request Jul 31, 2019
@erikmd
Don't clear $OPAMROOT/download-cache from coqorg/coq:dev
696ce07 
This patch will be unnecessary when PR ocaml/opam#3831 is released.
@erikmd
Copy link

erikmd commented Aug 2, 2019

Hi @rjbou @AltGr, I've seen you put the milestone 2.1.0 for this PR #3831 (which will be important to be able to run opam clean -c again in coqorg/coq:dev-based images and thus save ~110MB…)

Do you confirm that the upcoming release of opam will be 2.1.0, or do you plan to make a point release 2.0.x beforehand? (in which case would this PR be eligible to be shipped along?)

@erikmd
Copy link

erikmd commented Aug 2, 2019 •
edited
Loading

@rjbou @AltGr actually I've just seen that you opened some milestone for 2.0.6 :-)

Hence my question: would it be feasible for you to integrate the fix from PR #3831 in opam 2.0.6 ?

Kind regards, Erik

@rjbou
Copy link
Collaborator

rjbou commented Aug 7, 2019

There will be 2.0.6 & 2.1.0~beta releases. What we plan is that the 2.0 branch is the LTS one until 2.2.0, and its releases contains only bug fixes. By default, all PR are tagged 2.1.0 until backported to 2.0 branch for a release (cf. backported commits PRs).
We can integrate then this PR into 2.0.6.

@erikmd
Copy link

erikmd commented Aug 7, 2019

OK great! Thanks @rjbou for your explanation 👍

@rjbou rjbou mentioned this pull request Aug 30, 2019
Merged
erikmd added a commit to math-comp/docker-mathcomp that referenced this pull request Dec 2, 2019
@erikmd
Don't clear $OPAMROOT/download-cache from coqorg/coq:dev
58c8637 
This patch will be unnecessary when PR ocaml/opam#3831 is released.
@rjbou rjbou modified the milestones: 2.1.0, 2.0.6 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@AltGr @erikmd @rjbou