2.0.6 backported commits #3973
Merged
2.0.6 backported commits #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was #3886 going to go in as well, or is it already in? |
|
Could also do a release of ocaml-mccs (which I think fixes the GLPK vendoring properly) and switch 2.0 to use the +11 release? |
|
Of course, this PR is not fixed. Commits/PR proposals are welcome! |
rjbou
force-pushed
the
2.0.6
branch
2 times, most recently
from
74e08cc to
0038dcc
Compare
|
What about including the sorting feature in this upcoming release? |
|
@XVilka - that PR’s still WIP and adds a feature, not a bug fix, which isn’t how maintenance releases (are supposed to) work! |
|
I'd be in favour of including the bugfix #4038 in the next release (or removing the digest cache entirely) |
This is a quickfix, we can probably do better than that ; see ocaml#3828
bwrap/osx: do not fail if $HOME/.ccache is missing: check for directory existence in `add_mounts` See https://discuss.ocaml.org/t/dune-1-11-1-compilation-failed/4248 This was already present in bwrap, so only sandbox needs to be updated Signed-off-by: Marcello Seri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported commits for 2.0.6 release.
Also (not in this PR)