Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further sanity checks #3934

Merged
merged 8 commits into from
Jul 22, 2019
Merged

Further sanity checks #3934

merged 8 commits into from
Jul 22, 2019

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Jul 17, 2019

This brings #3929 to the 2.0 branch (checking install.sh is not strictly necessary, since it shouldn't be used from here, but it also pulls the infrastructure in). It then extends it with some more things from OCaml's CI to verify that configure is correctly committed.

@dra27
Copy link
Member Author

dra27 commented Jul 17, 2019

Example failure in https://travis-ci.org/ocaml/opam/jobs/559897064#L770

@dra27
Copy link
Member Author

dra27 commented Jul 17, 2019

Right, that's better - I've switched the Travis CI image from Trusty to Xenial, which means it pulls in the correctly patched version of autoconf. We could use the same patch as OCaml, but it's ugly and I think that @AltGr, @rjbou and I are all using versions of autoconf which include that patch anyway.

@rjbou
Copy link
Collaborator

rjbou commented Jul 18, 2019

LGTM, thanks!

@dra27
Copy link
Member Author

dra27 commented Jul 18, 2019

Cool - I'll open the parallel branch for master

@AltGr AltGr merged commit 43eca21 into ocaml:2.0 Jul 22, 2019
@rjbou rjbou mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants