-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to jbuilder #374
Port to jbuilder #374
Changes from 34 commits
dbb4963
0fa50d2
68b161f
30b8a80
de3d931
291f605
e721933
a988946
a384933
2da8764
e9f0907
512d277
e13bac7
7b6d9d0
94383e4
b28726b
b825120
d99fb6d
6c1705f
ffffdea
a926624
3b29534
49d909a
cd1e12c
5a044c6
a17ec27
c13e28a
20a979d
358f333
4973a51
353f501
b9ff5dc
890ccc2
d827388
ef6021c
b120197
ddc6330
b0551ea
67a34ac
455fe57
c075a63
dacbef8
0a33c49
7ca76aa
e0077c3
9fb2f5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,4 @@ | ||
_build | ||
src/unix/lwt_config.ml | ||
src/unix/lwt_config.h | ||
src/unix/lwt_unix_jobs_generated.ml | ||
src/unix/jobs-unix/ | ||
setup.data | ||
setup.log | ||
setup.exe | ||
|
@@ -15,3 +11,7 @@ _coverage/ | |
|
||
# For local work, tests, etc. | ||
scratch/ | ||
|
||
.merlin | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can also delete the root |
||
*.install | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,8 +8,8 @@ matrix: | |
env: COMPILER=4.03 | ||
- os: linux | ||
env: COMPILER=4.04 | ||
- os: linux | ||
env: COMPILER=4.05 | ||
#- os: linux | ||
# env: COMPILER=4.05 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't find any discussion in the jbuilder repo about 4.05. Do you or anyone have a link? This doesn't block the PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the bug may actually be related to a problem with 4.05+beta3, and it will work with 4.05+trunk |
||
- os: linux | ||
env: COMPILER=4.04 FLAMBDA=yes | ||
- os: linux | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,7 +119,7 @@ version, | |
opam source --dev-repo --pin lwt | ||
``` | ||
|
||
This will also install the development dependency OASIS. | ||
This will also install the development dependency jbuilder. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
A list of [project suggestions][projects] and a [roadmap][roadmap] can be found | ||
on the wiki. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
- Internal modules exposed in lwt-unit | ||
|
||
- lwt-unix configuration params passed to discover.exe; | ||
- use_libev (currently forced to true) | ||
- how do we depend on an external opam package with no findlib library? | ||
- android-target? | ||
|
||
- multi-workspace builds dont work | ||
- jbuilder build --workspace jbuild-workspace.dev @install @runtest --only-packages lwt | ||
- problem with ppx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the
setup.*
files can also be removed from.gitignore
.