Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octokit::Client#repository with wrong input #552

Closed
bsboris opened this issue Jan 22, 2015 · 0 comments
Closed

Octokit::Client#repository with wrong input #552

bsboris opened this issue Jan 22, 2015 · 0 comments

Comments

@bsboris
Copy link

bsboris commented Jan 22, 2015

Octokit::Client#repository('test') returns list of links from root url. Therefore Octokit::Client#repository?('test') returns true which is kind of wrong.
Shouldn't Octokit::Client#repository('test') throw Octokit::NotFound or ArgumentError?
@bsboris bsboris changed the title #repository with wrong input Octokit::Client#repository with wrong input Jan 22, 2015
@joeyw joeyw closed this as completed in 450b969 Feb 13, 2015
pengwynn added a commit that referenced this issue Feb 13, 2015
@pengwynn
Merge pull request #553 from octokit/check-for-valid-repo-string
96f0042 
Ensure Repository is valid when passed a string. Fixes #552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bsboris