Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Repository is valid when passed a string. Fixes #552 #553

Merged
merged 1 commit into from
Feb 13, 2015

Conversation

joeyw
Copy link
Contributor

@joeyw joeyw commented Jan 23, 2015

Raise an error when a Repository object is initialized with a string
that is not valid user/repo format.

Raise an error when a Repository object is initialized with a string
that is not valid user/repo format.
@joeyw
Copy link
Contributor Author

joeyw commented Jan 23, 2015

A little simple, maybe not thought out. I haven't pushed any code in a short while and well, I just kinda needed to, ya know.

@pengwynn
Copy link
Collaborator

Probably a good guard to have. I was playing around with a CLI thing the other night and found myself wanting to tweak this to handle both owner/repo and several flavors of GitHub URL.

pengwynn added a commit that referenced this pull request Feb 13, 2015
Ensure Repository is valid when passed a string. Fixes #552
@pengwynn pengwynn merged commit 96f0042 into master Feb 13, 2015
@pengwynn pengwynn deleted the check-for-valid-repo-string branch February 13, 2015 14:25
@pengwynn
Copy link
Collaborator

💰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants