Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when handle labels #561

Closed
serradura opened this issue Feb 13, 2015 · 0 comments · Fixed by #562
Closed

Bug when handle labels #561

serradura opened this issue Feb 13, 2015 · 0 comments · Fixed by #562

Comments

@serradura
Copy link

I can't update or delete a label with empty spaces or dash. But when I create its works.

Examples:

Octokit.delete_label!("myorg/myrepo", "0 - BACKLOG")
Octokit.delete_label!("myorg/myrepo", "not planned")

PS: The given example for delete a repository label isn't work.
pengwynn added a commit that referenced this issue Feb 13, 2015
@pengwynn
Don't CGI escape label names
be166fa 
Properly handle labels with spaces. Remove `CGI.escape`, let Addressable
handle it.

Fixes #560
Fixes #561
@pengwynn pengwynn mentioned this issue Feb 13, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't CGI escape label names octokit/octokit.rb
1 participant
@serradura