Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't CGI escape label names #562

Merged
merged 1 commit into from
Feb 13, 2015
Merged

Don't CGI escape label names #562

merged 1 commit into from
Feb 13, 2015

Conversation

pengwynn
Copy link
Collaborator

Properly handle labels with spaces. Remove CGI.escape, let Addressable handle it.

Fixes #560
Fixes #561

@pengwynn
Don't CGI escape label names
be166fa 
Properly handle labels with spaces. Remove `CGI.escape`, let Addressable
handle it.

Fixes #560
Fixes #561
pengwynn added a commit that referenced this pull request Feb 13, 2015
@pengwynn
Merge pull request #562 from octokit/label-escape-bug
e48a504 
Don't CGI escape label names
@pengwynn pengwynn merged commit e48a504 into master Feb 13, 2015
@pengwynn pengwynn deleted the label-escape-bug branch February 13, 2015 14:21
@domcleal
Copy link

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug when handle labels remove_label fails with 404 when label name contains spaces
2 participants
@pengwynn @domcleal