Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(declaration-type): fix missing return type on createWebhooksApi #137

Merged
merged 2 commits into from
May 18, 2020
Merged

🐛 fix(declaration-type): fix missing return type on createWebhooksApi #137

merged 2 commits into from
May 18, 2020

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented May 15, 2020 •
edited by gr2m
Loading

📝 Summary

  • Add missing return type of createWebhookApi on index.d.ts
  • Adapt typescript-validate to import index.d.ts properly

Fixes #136

📊 How Has This Been Tested?

Creating a dummy index.ts using the library and trying to compile it using tsc before and after applying the fix.

Before

image
image

After

image

@oscard0m oscard0m added the Type: Bug Something isn't working as documented, or is being fixed label May 15, 2020
@oscard0m oscard0m added the typescript Relevant to TypeScript users only label May 15, 2020
@oscard0m oscard0m linked an issue May 16, 2020 that may be closed by this pull request
Type error when using strict type checking #136
Closed
@oscard0m oscard0m mentioned this pull request May 16, 2020
Merged
@oscard0m oscard0m requested a review from gr2m May 16, 2020 11:50
gr2m
gr2m approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@gr2m gr2m merged commit 3ca68d5 into octokit:master May 18, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m gr2m mentioned this pull request May 18, 2020
Merged
@robcresswell
Copy link

Thanks @dominguezcelada @gr2m!

@oscard0m
Copy link
Member Author

Thanks @dominguezcelada @gr2m!

Thanks to you for reporting :)

@oscard0m oscard0m mentioned this pull request Jun 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type error when using strict type checking
3 participants
@oscard0m @robcresswell @gr2m