🐛 fix(type-declaration): add missing new named exports to generated types (index.d.ts): sign, verif #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes (index.d.ts): sign, verif
…ed export methods sign, verify
oscard0m
added
typescript
|
@SpencerKaiser If you have time, could you take a look just in case I'm missing any other method to be covered in |
|
@dominguezcelada just looked through the README and I didn't see anything else that's missing here. Thanks for fixing this so quickly!!! |
|
🎉 This PR is included in version 7.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Added missing named exports from latest changes on API to type declaration (
index.d.ts):verifysigncreateMiddlewarecreateEventHandler⛱ Motivation and Context
During the migration to new API giving support for named imports for main utility functions of this library it was not applied to
index.d.tstype declaration accordingly. (#126 and #137)Fix #152