-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ambiguous error codes #293
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -232,7 +232,8 @@ public void refreshTokenFailure() throws InterruptedException { | |
latch.await(); | ||
assertNull(cb.getResult()); | ||
assertNotNull(cb.getException()); | ||
assertEquals(cb.getException().getMessage(), "Invalid status code 401 Client Error"); | ||
assertEquals(cb.getException().getMessage(), "No client credentials found."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The original issue was saying we had multiple exceptions with the same type/code. Please add an assertion to confirm we fixed the original issue. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added the assertion below. |
||
assertEquals(cb.getException().type, TYPE_OAUTH_TOKEN_ERROR); | ||
} | ||
|
||
@Test | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okta-oidc-android/library/src/test/java/com/okta/oidc/util/JsonStrings.java
Line 241 in 6e0596b