Fixes ambiguous error codes #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaAvraimov-okta
force-pushed
the
na-OKTA-435843-ambiguous-error-codes
branch
from
d85ef8e to
5ebfb9d
Compare
NikitaAvraimov-okta
force-pushed
the
na-OKTA-435843-ambiguous-error-codes
branch
3 times, most recently
from
7319931 to
5b487e1
Compare
| @@ -232,7 +232,7 @@ public void refreshTokenFailure() throws InterruptedException { | |||
| latch.await(); | |||
| assertNull(cb.getResult()); | |||
| assertNotNull(cb.getException()); | |||
| assertEquals(cb.getException().getMessage(), "Invalid status code 401 Client Error"); | |||
| assertEquals(cb.getException().getMessage(), "No client credentials found."); | |||
There was a problem hiding this comment.
NikitaAvraimov-okta
force-pushed
the
na-OKTA-435843-ambiguous-error-codes
branch
from
5b487e1 to
5029117
Compare
JayNewstrom
suggested changes
Dec 21, 2021
| @@ -232,7 +232,7 @@ public void refreshTokenFailure() throws InterruptedException { | |||
| latch.await(); | |||
| assertNull(cb.getResult()); | |||
| assertNotNull(cb.getException()); | |||
| assertEquals(cb.getException().getMessage(), "Invalid status code 401 Client Error"); | |||
| assertEquals(cb.getException().getMessage(), "No client credentials found."); | |||
There was a problem hiding this comment.
The original issue was saying we had multiple exceptions with the same type/code. Please add an assertion to confirm we fixed the original issue.
There was a problem hiding this comment.
Added the assertion below.
NikitaAvraimov-okta
force-pushed
the
na-OKTA-435843-ambiguous-error-codes
branch
from
5029117 to
ab12651
Compare
JayNewstrom
approved these changes
Dec 22, 2021
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Dec 22, 2021
OKTA-435843 <<<Jenkins Check-In of Tested SHA: ab12651 for [email protected]>>> Artifact: okta-oidc-android Files changed count: 3 PR Link: "#293"
rajdeepnanua-okta
pushed a commit
that referenced
this pull request
Dec 14, 2023
Update to latest gradle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Testing details:
Other considerations:
RESOLVES:
OKTA-435843
#274
Primary Reviewer(s):
Additional Reviewers:
Security Reviewer(s) (@ okta/rex-team if necessary):
UX Reviewer(s) (if necessary):