Remove joinsession #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2022
|
|
|
Not quite sure what you mean. Insight will be the same, you have to use the id as username and password. I just still had to update the tooltip, which said use it only for the username (ome/omero-insight#296 ) |
|
in insight you only need to put the sessionID as username I think. I need to double-check |
|
Not with this PR. The check if a username is a session id was dealt with in the gateway. |
jburel
approved these changes
Nov 30, 2022
|
the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion ome/openmicroscopy#6319 . Removes the calls to
client.joinSession, onlyclient.createSessionis used. The check for session id login is kept, because the gateway uses it to decide if the session can be closed on disconnect.The implications for clients are:
Gateway.joinSessionmethod doesn't exist any longer(replaces #62 )