Remove joinSession #296
Merged
Remove joinSession #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we merge this PR together with ome/omero-gateway-java#63 @jburel ? |
|
I don't think that behaviour is documented anywhere. I know that ssbd uses the session to connect to the server. That will need to synch with them |
dominikl
force-pushed
the
remove_joinsession
branch
from
bf6ef96 to
a9fc725
Compare
|
Added a workaround if the session id is only pasted as username and password is empty. So no changes in behaviour for users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the calls to joinSession, see ome/omero-gateway-java#63 .