Fix borrowing #782

turbolent · 2021-04-08T20:43:53Z

(Port of #785, itself a port of dapperlabs/cadence-internal#1)

Description

Always check dynamic type when borrowing, checking, and dereferencing storage references
Check the dynamic type of all arguments against parameter types on each invocation

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

… storage references

… implementations

SupunS

Nice! 👏

turbolent added 8 commits April 8, 2021 13:11

always check dynamic type when borrowing, checking, and dereferencing…

d765769

… storage references

make error location more clear: panic with a dedicated error message

9d24b47

check dynamic type of all arguments against parameter types

4978952

only wrap error in positioned error if statement is available

9bd5305

fix qualified identifier for signature verifier and hasher

34ab4c1

properly register composite types for signature verififier and hasher…

b8482c7

… implementations

add additional test for argument type check

9c7824b

remove unnecessary parameter type count check

47b8400

turbolent added the Bugfix label Apr 8, 2021

turbolent requested review from SupunS and janezpodhostnik April 8, 2021 20:43

turbolent self-assigned this Apr 8, 2021

turbolent mentioned this pull request Apr 8, 2021

Extend defensive run-time checking to all value transfers #784

Merged

6 tasks

SupunS approved these changes Apr 9, 2021

View reviewed changes

turbolent merged commit 0b1a155 into master Apr 12, 2021

turbolent deleted the bastian/fix-borrowing branch April 12, 2021 16:50