Fix borrowing #785

turbolent · 2021-04-08T22:08:23Z

Publication of already deployed dapperlabs/cadence-internal#1.
(Same commits, see https://github.com/dapperlabs/cadence-internal/pull/1/commits)

Description

Always check dynamic type when borrowing, checking, and dereferencing storage references
Check the dynamic type of all arguments against parameter types on each invocation

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

… storage references

… implementations

turbolent added 8 commits March 24, 2021 16:12

always check dynamic type when borrowing, checking, and dereferencing…

eab7ce4

… storage references

make error location more clear: panic with a dedicated error message

a2a1aa3

check dynamic type of all arguments against parameter types

e71cce0

only wrap error in positioned error if statement is available

9447d4d

fix qualified identifier for signature verifier and hasher

82955e1

properly register composite types for signature verififier and hasher…

bf7fe7c

… implementations

add additional test for argument type check

4d8d12e

remove unnecessary parameter type count check

fb9068c

turbolent added the Bugfix label Apr 8, 2021

turbolent requested a review from SupunS April 8, 2021 22:08

turbolent self-assigned this Apr 8, 2021

zhangchiqing approved these changes Apr 9, 2021

View reviewed changes

turbolent merged commit 83283be into v0.14 Apr 9, 2021

turbolent deleted the bastian/fix-borrowing-v0.14 branch April 9, 2021 00:27

turbolent mentioned this pull request Apr 9, 2021

Fix borrowing #782

Merged

6 tasks