Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change member access semantics #89

Merged
merged 8 commits into from
Jul 5, 2023
Merged

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented May 17, 2023

No description provided.

@SupunS SupunS force-pushed the supun/member-access-semantics branch 3 times, most recently from 228d48c to 13bfda0 Compare May 17, 2023 23:58
@SupunS SupunS force-pushed the supun/member-access-semantics branch from 13bfda0 to 2d5e032 Compare May 18, 2023 00:02
Copy link
Contributor

@dsainati1 dsainati1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I am in favor of this change because it interacts well with the new entitlements changes and also has potential for helping out the mutability problem.

Co-authored-by: Jan Bernatik <[email protected]>
@SupunS SupunS marked this pull request as ready for review May 19, 2023 22:50
@SupunS SupunS force-pushed the supun/member-access-semantics branch from a2996d9 to dd2825b Compare May 31, 2023 21:27
@SupunS SupunS self-assigned this Jun 1, 2023
@SupunS SupunS changed the title Change Member Access Semantics Change member access semantics Jun 13, 2023
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


More details on this problem is described in the [FLIP for improving mutability restrictions](https://github.com/onflow/flips/pull/58).

This proposal is aimed at moving one step closer to solving this problem by returning references for member-access,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A strong misson statement here, and a good reason to do it. love it.

@turbolent
Copy link
Member

@SupunS there has not been any additional feedback for multiple weeks, let's approve and merge 🎉

@turbolent turbolent merged commit 5f318f4 into main Jul 5, 2023
@turbolent turbolent deleted the supun/member-access-semantics branch July 5, 2023 20:51
dsainati1 pushed a commit that referenced this pull request Jul 11, 2023
Co-authored-by: Jan Bernatik <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants