Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external mutability improvements #2718

Merged
merged 102 commits into from
Aug 15, 2023
Merged

Add external mutability improvements #2718

merged 102 commits into from
Aug 15, 2023

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Aug 15, 2023 •
edited
Loading

Closes #2638

Description

Implementation of the changes proposedin FLIPs:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

SupunS added 30 commits June 9, 2023 15:04
@SupunS
Change member access result type to a reference
9743293
@SupunS
Fix attachment 'self' access
ece3d8f
@SupunS
Update interpreter member access
ccc053e
@SupunS
Update tests
e26ff54
@SupunS
Fix more tests
ab854e2
@SupunS
Add member-acess expr to static reference validity checking
85d294a
@SupunS
Add test for static attachment invalidation
0421eb0
@SupunS
Refactor code
b965147
@SupunS
Add more tests
aabca06
@SupunS
Merge branch 'feature/entitlements' of https://github.com/onflow/cadence
fc5ea48 
 into supun/member-access-semantics
@SupunS
Update to match entitlements
04e7ac8
@SupunS
Add built-in entitlements
f0f77d2
@SupunS
Auto regiter generated entitlements
5845813
@SupunS
Add builtin entitlements to array functions
9b9c937
@SupunS
Re-use pre-computed results from checker
5c8ea34
@SupunS
Improve tests
eca92df
@SupunS
Add test for index expression resource loss
498c63a
@SupunS
Refactor checking access modifiers
5dceaa6
@SupunS
Pass authorization to members
b5e26fc
@SupunS
Simplify reference creation
5157711
@SupunS
Merge branch 'supun/member-access-semantics' into supun/entitlement-i…
81a8c8f 
…mprovements
@SupunS
Simplify reference creation for index expressions
dadf1c3
@SupunS
Merge branch 'supun/member-access-semantics' into supun/entitlement-i…
8b45a77 
…mprovements
@SupunS
Pass down proper authorization for member-access on reference
b33b86c
@SupunS
Fix tests
5165954
@SupunS
Pass proper entitlements to index expression members
bd13b6e
@SupunS
Merge branch 'supun/entitlement-improvements' into supun/use-builtin-…
0970761 
…entitlements
@SupunS
Add identity mapping
388d662
@SupunS
Merge branch 'supun/identity-mapping' into supun/use-builtin-entitlem…
f7b554c 
…ents
@SupunS
Update tests
c2699ab
SupunS and others added 17 commits July 6, 2023 13:15
@SupunS
Merge branch 'feature/mutability-restrictions' of https://github.com/…
899a0fa 
…onflow/cadence into supun/identity-mapping-improvement
@SupunS
Return all supported entitlements for owned value's fields
a54cad8
@SupunS
Add more tests
842a9cd
@SupunS
Merge pull request #2637 from onflow/supun/identity-mapping-improvement
e8c73bd 
Return a reference with all entitlements, when access through owned values
@SupunS
Merge branch 'feature/mutability-restrictions' of https://github.com/…
b7d6df2 
…onflow/cadence into supun/entitled-assigment
@SupunS
Update tests
97ab8c0
@SupunS
Add more tests
57821ec
@SupunS
Requrie mutablity entitlements for index assignment
34b30d5
@SupunS
Conform dictionaries and arrays to EntitlementSupportingType
ae64ba2
@SupunS
Remove redundant nil check
c142c39
@SupunS
Merge pull request #2664 from onflow/supun/entitled-assigment
5b47d1a 
Make indexing assignment entitled
@SupunS
Rename mutability entitlements
5d40cd1
@SupunS
Merge pull request #2690 from onflow/supun/rename-entitlements
894095b 
Rename mutability entitlements
@turbolent
Merge branch 'feature/stable-cadence' into bastian/mutability-restric…
9093316 
…tions
@turbolent
lint: delete unused code
01186e8
@turbolent
lint
7f32297
@turbolent
Merge pull request #2714 from onflow/bastian/mutability-restrictions
4acc8de
@SupunS SupunS added Language Breaking Change Breaks Cadence contracts deployed on Mainnet Feature labels Aug 15, 2023
@SupunS SupunS self-assigned this Aug 15, 2023
@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/stable-cadence commit 341b7b5
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2150µs ± 0%159µs ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-248.2µs ± 0%57.8µs ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsCCF-2175ms ± 0%189ms ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-2603ms ± 0%609ms ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-23.88µs ± 0%4.01µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-22.94µs ± 0%3.09µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-23.88µs ± 0%4.25µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-24.24µs ± 0%4.41µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-23.02µs ± 0%3.25µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-23.67µs ± 0%3.83µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-23.49µs ± 0%3.56µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-23.49µs ± 0%3.80µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-22.94µs ± 0%2.91µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-23.75µs ± 0%3.75µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-221.8µs ± 0%16.2µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-213.7µs ± 0%8.4µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-217.6µs ± 0%13.3µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-219.5µs ± 0%18.3µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-29.03µs ± 0%8.69µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-211.7µs ± 0%11.5µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-211.7µs ± 0%12.3µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-211.7µs ± 0%10.6µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-28.55µs ± 0%8.85µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-212.3µs ± 0%12.0µs ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsCCF-288.6ms ± 0%100.5ms ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-2161ms ± 0%190ms ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-22.03µs ± 0%2.71µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-21.58µs ± 0%2.60µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-22.02µs ± 0%2.86µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-22.22µs ± 0%3.06µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-21.55µs ± 0%2.83µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-21.76µs ± 0%2.70µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-21.86µs ± 0%2.14µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-21.83µs ± 0%2.00µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-21.55µs ± 0%1.70µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-21.87µs ± 0%2.05µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-23.87µs ± 0%3.85µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-22.17µs ± 0%2.16µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-23.44µs ± 0%3.50µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-24.86µs ± 0%5.25µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-22.23µs ± 0%2.27µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-22.80µs ± 0%3.06µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-23.29µs ± 0%3.45µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-22.62µs ± 0%2.67µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-22.14µs ± 0%2.20µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-23.34µs ± 0%3.27µs ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-2425ns ± 0%435ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-293.2ns ± 0%103.2ns ± 0%~(p=1.000 n=1+1)
InterpretRecursionFib-22.77ms ± 0%3.00ms ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-21.65µs ± 0%1.54µs ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-2729ns ± 0%704ns ± 0%~(p=1.000 n=1+1)
ParseArray-29.86ms ± 0%8.94ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-215.1ms ± 0%12.9ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-21.53ms ± 0%1.46ms ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-2245µs ± 0%241µs ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-2190µs ± 0%195µs ± 0%~(p=1.000 n=1+1)
ParseInfix-27.83µs ± 0%7.53µs ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-22.73ns ± 0%2.88ns ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-2145ns ± 0%154ns ± 0%~(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-26.55ms ± 0%6.47ms ± 0%~(p=1.000 n=1+1)
RuntimeResourceTracking-20.02ns ± 0%0.02ns ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-25.54µs ± 0%5.89µs ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-2403ns ± 0%401ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/composites-2165ns ± 0%162ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/integers-2186ns ± 0%191ns ± 0%~(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-2115ns ± 0%121ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-253.6kB ± 0%53.4kB ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-226.0kB ± 0%26.0kB ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsCCF-267.3MB ± 0%67.3MB ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-2246MB ± 0%246MB ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-21.41kB ± 0%1.41kB ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-21.22kB ± 0%1.22kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-21.49kB ± 0%1.49kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-21.50kB ± 0%1.50kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-21.26kB ± 0%1.26kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-21.38kB ± 0%1.38kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-21.34kB ± 0%1.34kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-21.33kB ± 0%1.33kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-21.22kB ± 0%1.22kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-21.35kB ± 0%1.35kB ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-26.02kB ± 0%6.02kB ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-23.62kB ± 0%3.62kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-25.45kB ± 0%5.45kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-27.37kB ± 0%7.37kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-23.66kB ± 0%3.66kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-24.55kB ± 0%4.55kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-24.91kB ± 0%4.91kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-24.49kB ± 0%4.49kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-23.62kB ± 0%3.62kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-24.91kB ± 0%4.91kB ± 0%~(all equal)
EncodeBatchEventsCCF-237.1MB ± 0%37.1MB ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-234.0MB ± 0%34.0MB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-2736B ± 0%736B ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-2688B ± 0%688B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-2800B ± 0%800B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-2768B ± 0%768B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-2704B ± 0%704B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-2784B ± 0%784B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-2752B ± 0%752B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-2736B ± 0%736B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-2688B ± 0%688B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-2752B ± 0%752B ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-2768B ± 0%768B ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-2408B ± 0%408B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-2760B ± 0%760B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-2952B ± 0%952B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-2424B ± 0%424B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-2624B ± 0%624B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-2680B ± 0%680B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-2544B ± 0%544B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-2416B ± 0%416B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-2672B ± 0%672B ± 0%~(all equal)
ExportType/composite_type-2136B ± 0%136B ± 0%~(all equal)
ExportType/simple_type-20.00B 0.00B ~(all equal)
InterpretRecursionFib-21.00MB ± 0%1.00MB ± 0%~(all equal)
NewInterpreter/new_interpreter-2976B ± 0%976B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-2200B ± 0%200B ± 0%~(all equal)
ParseArray-22.74MB ± 0%2.65MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-24.31MB ± 0%4.29MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-2214kB ± 0%214kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-229.7kB ± 0%29.7kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-229.7kB ± 0%29.7kB ± 0%~(p=1.000 n=1+1)
ParseInfix-21.92kB ± 0%1.92kB ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeResourceDictionaryValues-22.30MB ± 0%2.30MB ± 0%~(p=1.000 n=1+1)
RuntimeResourceTracking-20.00B 0.00B ~(all equal)
RuntimeScriptNoop-23.26kB ± 0%3.26kB ± 0%~(all equal)
SuperTypeInference/arrays-296.0B ± 0%96.0B ± 0%~(all equal)
SuperTypeInference/composites-20.00B 0.00B ~(all equal)
SuperTypeInference/integers-20.00B 0.00B ~(all equal)
ValueIsSubtypeOfSemaType-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-2853 ± 0%853 ± 0%~(all equal)
ContractInterfaceFungibleToken-2393 ± 0%393 ± 0%~(all equal)
DecodeBatchEventsCCF-21.48M ± 0%1.48M ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-24.70M ± 0%4.70M ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-230.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-226.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-230.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-232.0 ± 0%32.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-226.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-229.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-231.0 ± 0%31.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-229.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-226.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-231.0 ± 0%31.0 ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-2126 ± 0%126 ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-271.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-2102 ± 0%102 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-2159 ± 0%159 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-270.0 ± 0%70.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-287.0 ± 0%87.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-295.0 ± 0%95.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-286.0 ± 0%86.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-271.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-295.0 ± 0%95.0 ± 0%~(all equal)
EncodeBatchEventsCCF-2467k ± 0%467k ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-2757k ± 0%757k ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-217.0 ± 0%17.0 ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-214.0 ± 0%14.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-223.0 ± 0%23.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-213.0 ± 0%13.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-217.0 ± 0%17.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-212.0 ± 0%12.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-211.0 ± 0%11.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-216.0 ± 0%16.0 ± 0%~(all equal)
ExportType/composite_type-23.00 ± 0%3.00 ± 0%~(all equal)
ExportType/simple_type-20.00 0.00 ~(all equal)
InterpretRecursionFib-218.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-216.0 ± 0%16.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-24.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-259.6k ± 0%59.6k ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-289.4k ± 0%89.4k ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-263.0 ± 0%63.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-2778 ± 0%778 ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-2778 ± 0%778 ± 0%~(all equal)
ParseInfix-248.0 ± 0%48.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeResourceDictionaryValues-237.7k ± 0%37.7k ± 0%~(p=1.000 n=1+1)
RuntimeResourceTracking-20.00 0.00 ~(all equal)
RuntimeScriptNoop-252.0 ± 0%52.0 ± 0%~(all equal)
SuperTypeInference/arrays-23.00 ± 0%3.00 ± 0%~(all equal)
SuperTypeInference/composites-20.00 0.00 ~(all equal)
SuperTypeInference/integers-20.00 0.00 ~(all equal)
ValueIsSubtypeOfSemaType-21.00 ± 0%1.00 ± 0%~(all equal)
 

@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #2718 (4acc8de) into feature/stable-cadence (341b7b5) will decrease coverage by 0.09%.
The diff coverage is 79.31%.

@@                    Coverage Diff                     @@
##           feature/stable-cadence    #2718      +/-   ##
==========================================================
- Coverage                   79.40%   79.32%   -0.09%     
==========================================================
  Files                         336      337       +1     
  Lines                       80137    80444     +307     
==========================================================
+ Hits                        63634    63810     +176     
- Misses                      14207    14335     +128     
- Partials                     2296     2299       +3
Flag Coverage Δ
unittests 79.32% <79.31%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
runtime/sema/account_capability_controller.gen.go 100.00% <ø> (ø)
runtime/sema/block.gen.go 100.00% <ø> (ø)
runtime/sema/character.gen.go 100.00% <ø> (ø)
runtime/sema/deployedcontract.gen.go 100.00% <ø> (ø)
runtime/sema/storage_capability_controller.gen.go 100.00% <ø> (ø)
runtime/sema/gen/main.go 84.68% <32.71%> (-4.45%) ⬇️
runtime/interpreter/interpreter.go 88.04% <45.94%> (-0.51%) ⬇️
runtime/sema/checker.go 92.12% <82.11%> (+0.02%) ⬆️
runtime/sema/type.go 88.82% <83.33%> (+<0.01%) ⬆️
runtime/interpreter/interpreter_expression.go 86.25% <92.00%> (-1.34%) ⬇️
... and 10 more

... and 1 file with indirect coverage changes

@turbolent
Copy link
Member

@SupunS The FLIP got approved, so this implementation can be merged 🎉

@SupunS SupunS marked this pull request as ready for review August 15, 2023 18:18
turbolent
turbolent approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@SupunS SupunS merged commit c9938e6 into feature/stable-cadence Aug 15, 2023
@turbolent turbolent deleted the feature/mutability-restrictions branch September 1, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsainati1 dsainati1 dsainati1 approved these changes

@turbolent turbolent turbolent approved these changes

Assignees

@SupunS SupunS

Labels
Feature Language Breaking Change Breaks Cadence contracts deployed on Mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SupunS @turbolent @dsainati1